Back to Forum | View unanswered posts | View active topics



Post new topic Reply to topic  Page 1 of 1
  [ 2 posts ] 
  Print view | E-mail friend Previous topic | Next topic 
Author Message
Guest
 Post subject: Singular defines macros generating conflicts in Sagemath
PostPosted: Mon Dec 06, 2021 4:50 pm 
Hi,
In SageMath, Singular generates the file factory.h which defines the macro #define IntegerDomain 1.
This conflict with Givaro's code using a class IntegerDomain with the Givaro namespace.

See the discussion here on sage-devel (sorry I can't post a link)


Would it be possible to avoid leaving C macros defined in the precompiler namespace, this is likely to generate such conflicts, especially with natural names in camel case like in this case.
- a first option could be to undefine the macro after it has been used
- or to rename the macro with a Singular specific prefix, like __SINGULAR

Thanks for your help.
Best.
Clément


Report this post
Top
  
Reply with quote  
hannes
 Post subject: Re: Singular defines macros generating conflicts in Sagemath
PostPosted: Mon Dec 06, 2021 5:26 pm 

Joined: Wed May 25, 2005 4:16 pm
Posts: 275
IntegerDomain can be less public, that should solve this problem:
see https://github.com/Singular/Singular/commit/18bb792edcc6d3f65af0111f93ed61118123ffd1


Report this post
Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  Page 1 of 1
  [ 2 posts ] 

You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

It is currently Fri May 13, 2022 10:54 am
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group